Refactor: add parser message template #11192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
JLHwung
commented
Mar 1, 2020
| // $FlowIgnore | ||
| const err: SyntaxError & { pos: number, loc: Position } = new SyntaxError( | ||
| const message = | ||
| errorTemplate.replace(/%(\d+)/g, (_, i: number) => params[i]) + |
There was a problem hiding this comment.
The error message now supports naive %0-style templates.
|
I am not sure if I should do this for TypeScript plugin because the way ts compiler indexes diagnostics is quite brutal: https://github.com/microsoft/TypeScript/blob/9c71eaf59040ae75343da8cdff01344020f5bba2/lib/diagnosticMessages.generated.json |
|
We should probably diverge from their error codes, and be consistent with the other parts of our parser. |
JLHwung
force-pushed
the
refactor-parser-message-template
branch
from
3321481
to
5ededb5
Compare
|
Time for a lint rule that prevents |
existentialism
approved these changes
Mar 3, 2020
hzoo
approved these changes
Mar 3, 2020
Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
JLHwung
force-pushed
the
refactor-parser-message-template
branch
from
63bd85c
to
1af4064
Compare
nicolo-ribaudo
approved these changes
Mar 3, 2020
This was referenced Mar 7, 2020
This was referenced Apr 11, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects the scattered babel parser error messages into a centralized message store. By doing so we can implement expression scops which records different types of errors when parsing ambiguous patterns.
The naming conventions of error messages strictly follows v8's message template if they exists, otherwise I coin some phrase so PTAL on the message template. 🙏
Todo